drivers: flash: stm32wba flash driver moves sem functions #82861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CONFIG_BT_STM32WBA the stm32wba_fm flash driver is compiled and must takes flash_stm32_sem_take/give functions from the flash_stm32.h header file, like other stm32 series. Signed-off-by: Francois Ramu <[email protected]>
FRASTM
requested review from
asm5878,
duda-patryk,
erwango,
gautierg-st and
nordicjm
asm5878
approved these changes
Dec 11, 2024
duda-patryk
reviewed
Dec 11, 2024
zephyrbot
requested review from
GeorgeCGV,
de-nordic,
marwaiehm-st,
mathieuchopstm and
rghaddab
erwango
approved these changes
Dec 13, 2024
de-nordic
approved these changes
Dec 13, 2024
duda-patryk
approved these changes
Dec 13, 2024
gautierg-st
approved these changes
Dec 16, 2024
nordicjm
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the CONFIG_BT_STM32WBA, the stm32wba_fm flash driver is compiled and must have flash_stm32_sem_take/give functions from the flash_stm32.h header file, like other stm32 series.
Following the PR #76640 and commit ff0f1e5, the flash_stm32_sem_take() _flash_stm32_sem_take() are now in the drivers/flash/flash_stm32.h
This PR will avoid error when building samples/bluetooth/peripheral/ for example on nucleo_wba55cg target
Since the CONFIG_BT_STM32WBA is defined, the flash_stm32wba_fm.c is used for the stm32 flash driver
failing with a redefinition of _flash_stm32_sem_take() _flash_stm32_sem_give() functions